Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use raw-dylib for windows-sys #1137

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Use raw-dylib for windows-sys #1137

merged 2 commits into from
Jul 8, 2024

Conversation

NobodyXu
Copy link
Collaborator

@NobodyXu NobodyXu commented Jul 7, 2024

To avoid having to declare #[link(name = "...")]

@NobodyXu NobodyXu requested a review from ChrisDenton July 7, 2024 13:25
@NobodyXu
Copy link
Collaborator Author

NobodyXu commented Jul 7, 2024

@ChrisDenton Seems like it doesn't work https://github.com/rust-lang/cc-rs/actions/runs/9827681479/job/27130657478?pr=1137#step:8:18

    Updating crates.io index
     Locking 44 packages to latest compatible versions
      Adding linux-raw-sys v0.4.14 (latest: v0.6.4)
      Adding which v4.4.2 (latest: v6.0.1)
   Compiling cc v1.0.105 (D:\a\cc-rs\cc-rs)
   Compiling gen-target-info v0.1.0 (D:\a\cc-rs\cc-rs\dev-tools\gen-target-info)
   Compiling gen-windows-sys-binding v0.0.0 (D:\a\cc-rs\cc-rs\dev-tools\gen-windows-sys-binding)
   Compiling cc-test v0.1.0 (D:\a\cc-rs\cc-rs\dev-tools\cc-test)
error: failed to run custom build command for `cc-test v0.1.0 (D:\a\cc-rs\cc-rs\dev-tools\cc-test)`

Caused by:
  process didn't exit successfully: `D:\a\cc-rs\cc-rs\target\debug\build\cc-test-5525a8762191208f\build-script-build` (exit code: 0xc0000139, STATUS_ENTRYPOINT_NOT_FOUND)
warning: build failed, waiting for other jobs to finish...

@NobodyXu NobodyXu mentioned this pull request Jul 7, 2024
Merged
@NobodyXu
Copy link
Collaborator Author

NobodyXu commented Jul 8, 2024

Seems that it needs msrv 1.67 rust-lang/rust#104360 (comment)

NobodyXu added a commit that referenced this pull request Jul 8, 2024
@NobodyXu
Bump msrv to 1.67
e1bf19e 
For #1137

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu mentioned this pull request Jul 8, 2024
Merged
NobodyXu added a commit that referenced this pull request Jul 8, 2024
@NobodyXu
Bump msrv to 1.67 (#1143)
5a1efa2 
For #1137

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
NobodyXu and others added 2 commits July 8, 2024 21:29
@NobodyXu
Use raw-dylib for windows-sys
c15bcbf 
To avoid having to declare `#[link(name = "...")]`

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu @ChrisDenton
Update windows_targets.rs
02ecf8f 
Co-authored-by: Chris Denton <chris@chrisdenton.dev>
@NobodyXu NobodyXu merged commit f657ba1 into main Jul 8, 2024
50 checks passed
@NobodyXu NobodyXu deleted the windows-sys-rar-dynlibi branch July 8, 2024 11:34
@github-actions github-actions bot mentioned this pull request Jul 8, 2024
Merged
@tnull tnull mentioned this pull request Jul 8, 2024
Closed
@bjorn3 bjorn3 mentioned this pull request Jul 13, 2024
Closed
NobodyXu added a commit that referenced this pull request Jul 14, 2024
@NobodyXu
Revert "Use raw-dylib for windows-sys (#1137)"
b119aa5 
This reverts commit f657ba1.
@NobodyXu NobodyXu mentioned this pull request Jul 14, 2024
Merged
NobodyXu added a commit that referenced this pull request Jul 14, 2024
@NobodyXu
Revert "Use raw-dylib for windows-sys (#1137)" (#1157)
a412806
@github-actions github-actions bot mentioned this pull request Jul 14, 2024
Merged
@NobodyXu NobodyXu mentioned this pull request Jul 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisDenton ChrisDenton ChrisDenton left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NobodyXu @ChrisDenton